feat: configure sketchbook location without restart #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
force-pushed
the
#1764-signed
branch
3 times, most recently
from
3efc3fd to
2d8267d
Compare
kittaakos
commented
Dec 15, 2022
arduino-ide-extension/src/browser/contributions/archive-sketch.ts
Outdated
Show resolved
Hide resolved
kittaakos
commented
Dec 15, 2022
kittaakos
commented
Dec 15, 2022
arduino-ide-extension/src/browser/contributions/save-as-sketch.ts
Outdated
Show resolved
Hide resolved
kittaakos
commented
Dec 15, 2022
kittaakos
commented
Dec 15, 2022
kittaakos
commented
Dec 15, 2022
arduino-ide-extension/src/browser/local-cache/local-cache-fs-provider.ts
Outdated
Show resolved
Hide resolved
kittaakos
commented
Dec 15, 2022
arduino-ide-extension/src/browser/sketches-service-client-impl.ts
Outdated
Show resolved
Hide resolved
kittaakos
commented
Dec 15, 2022
arduino-ide-extension/src/browser/theia/monaco/monaco-text-model-service.ts
Outdated
Show resolved
Hide resolved
kittaakos
commented
Dec 15, 2022
arduino-ide-extension/src/browser/widgets/sketchbook/sketchbook-tree-model.ts
Outdated
Show resolved
Hide resolved
kittaakos
commented
Dec 15, 2022
kittaakos
commented
Dec 15, 2022
kittaakos
commented
Dec 15, 2022
arduino-ide-extension/src/electron-browser/theia/core/electron-main-menu-factory.ts
Outdated
Show resolved
Hide resolved
kittaakos
commented
Dec 15, 2022
arduino-ide-extension/src/electron-browser/theia/core/electron-main-menu-factory.ts
Outdated
Show resolved
Hide resolved
kittaakos
commented
Dec 15, 2022
kittaakos
commented
Dec 15, 2022
kittaakos
requested review from
per1234 and
AlbyIanna
and removed request for
per1234
kittaakos
added
type: enhancement
per1234
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
I verified this fixes:
- IDE hangs on startup if drive containing sketchbook location not accessible #1764
- IDE UI does not reflect changed "Sketchbook location" preference #796
- If Sketchbook is empty, no Sketchbook menu item is present under File #569
- Show "Tools > Port" menu even when empty #655
Thanks Akos!
Closes #1764 Closes #796 Closes #569 Closes #655 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
force-pushed
the
#1764-signed
branch
from
9caaa2c to
6273734
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
directories.userpath inarduino-cli.yamlat app startup.File>Sketchbookmenu item even if no sketches are in the folder.Tools>Portmenu item even if there are no available ports.Preview:
1764_preview.mp4
Change description
directories.useris invalid or does not exist.directories.useris not a valid directory, IDE2 toasts an error message at startup.Save As...,Open,Archive Sketch, andAdd .ZIP Library...are fully functional when there is no validdirectories.uservalue is set.directories.userdoes not exist, IDE2 tries to create the folder.directories.userlocation from the IDE2's Settings dialog.directories.user,File>Sketchbook,File>Examples, andSketch> Include Library` submenus update.directories.useris invalid or empty,File>Sketchbookis visible but disabled.Tools>Portis visible but disabled when no available ports are detected.Other information
Closes #1764
Closes #796
Closes #569
Closes #655
Reviewer checklist